batched_embedding_kernel int32 support behind jk #3164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77843259 |
|
This pull request was exported from Phabricator. Differential Revision: D77843259 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D77843259 |
|
This pull request was exported from Phabricator. Differential Revision: D77843259 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
Summary: ### tl;dr After this diff stack int32 indices and offsets will be supported for FBGEMM embedding lookup kernels. This will be able to enabled via config on APS. ### Implementation https://docs.google.com/document/d/1GoFghmJcDSGf6XhVkoTJs4C0jTemvpGe1fCNi6oQDRo/edit?usp=sharing ### Context https://docs.google.com/document/d/1YVfxsafqXkxAAdRyXbjmSH4AEz3-6DBiTGjs1rT8ZHQ/edit?usp=sharing ### Diff specific changes Putting the ability to cast to int32 behind jk killswitch which we can turn off at any time in torchrec. ### JK https://www.internalfb.com/intern/justknobs/?name=fbgemm_gpu%2Ffeatures&name=fbgemm_gpu%2Ffeatures#INT32_INDICES Differential Revision: D77843259
facebook-github-bot
force-pushed
the
export-D77843259
branch
from
122b25d to
b17ed81
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77843259 |
Summary: ### tl;dr After this diff stack int32 indices and offsets will be supported for FBGEMM embedding lookup kernels. This will be able to enabled via config on APS. ### Implementation https://docs.google.com/document/d/1GoFghmJcDSGf6XhVkoTJs4C0jTemvpGe1fCNi6oQDRo/edit?usp=sharing ### Context https://docs.google.com/document/d/1YVfxsafqXkxAAdRyXbjmSH4AEz3-6DBiTGjs1rT8ZHQ/edit?usp=sharing ### Diff specific changes Putting the ability to cast to int32 behind jk killswitch which we can turn off at any time in torchrec. ### JK https://www.internalfb.com/intern/justknobs/?name=fbgemm_gpu%2Ffeatures&name=fbgemm_gpu%2Ffeatures#INT32_INDICES Differential Revision: D77843259
facebook-github-bot
force-pushed
the
export-D77843259
branch
from
b17ed81 to
d9fcec5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77843259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
tl;dr
After this diff stack int32 indices and offsets will be supported for FBGEMM embedding lookup kernels. This will be able to enabled via config on APS.
Implementation
https://docs.google.com/document/d/1GoFghmJcDSGf6XhVkoTJs4C0jTemvpGe1fCNi6oQDRo/edit?usp=sharing
Context
https://docs.google.com/document/d/1YVfxsafqXkxAAdRyXbjmSH4AEz3-6DBiTGjs1rT8ZHQ/edit?usp=sharing
Diff specific changes
Putting the ability to cast to int32 behind jk killswitch which we can turn off at any time in torchrec.
Differential Revision: D77843259